Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zig support using zls. #3232

Merged
merged 1 commit into from
Jul 11, 2020
Merged

Zig support using zls. #3232

merged 1 commit into from
Jul 11, 2020

Conversation

cherryman
Copy link
Contributor

No description provided.

@cherryman
Copy link
Contributor Author

Can't seem to figure out why the CI is failing, the headings seem correct when I test them.

@cherryman
Copy link
Contributor Author

Closes #2484.

@hsanson
Copy link
Contributor

hsanson commented Jul 11, 2020

@cherryman in the doc/ale.txt file add one blank line after line 2680, that is after the zls entry you added. After adding the line you can run the test//script/check-toc script directly to see if the error is gone.

@cherryman
Copy link
Contributor Author

@hsanson Thanks, that worked.

Copy link
Contributor

@hsanson hsanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not Zig or zls but the PR seems ok. It has docs and tests.

@hsanson hsanson merged commit 26571fa into dense-analysis:master Jul 11, 2020
@dav1dnix
Copy link

dav1dnix commented Dec 14, 2020

Hi, I am unable to get zls working even though I have it installed. I can run it from terminal just fine, but ALE does not recognise it. Here are my linters:

let g:ale_linters = {
    \ 'javascript': ['tsserver'],
    \ 'typescript': ['tsserver'],
    \ 'yaml': ['yamllint'],
    \ 'go': ['gopls'],
    \ 'python': ['flake8'],
    \ 'zig': ['zls'],
    \ }

But if I open a file with extension .zig, here is what ALEInfo shows me:

Available Linters: []
  Enabled Linters: []
  Ignored Linters: []

Edit: had to add this plugin to my init.vim and it worked https://github.com/ziglang/zig.vim Plug 'ziglang/zig.vim'

@cherryman
Copy link
Contributor Author

@Dps910 I suspect that without Plug 'ziglang/zig.vim', filetype wasn't being set to zig as it's supposed to, and so this part of the plugin wasn't being loaded. This is intentional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants