-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Astyle Project Option Detection when Placed with Source Files #3257
Fix Astyle Project Option Detection when Placed with Source Files #3257
Conversation
Hmm. I think the Travis CI - PR has been duplicated for some reason. The queued Travis check references the tests that were already run (and have passed). |
@jhlink I can confirm that this works as intended and fixes the bug #3256 as intended! I have not checked out the tests, but the implementation is gold.
Thanks for the quick turnaround on this. And THANK YOU for implementing astyle in the first place, seriously appreciate it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick response in fixing this. I have tested with C/C++ small projects using .astylerc files in the root and works as expected.
Changes are ok and my limited tests show it works as advertised. Unfortunately the CI checks have not completed for some reason and I cannot merge this until they are finished. |
Awesome. Thanks @hsanson !! I'm stumped as to why CI is hanging. According to the build page, the run was successful. According to other forums, it seems more like a status update problem. 😕 But I guess I'll wait and see. If there's no change by tomorrow, I'll see if pushing an empty commit will change anything. 🤞 |
Lol... sometimes in power critical embedded applications, there's a "watchdog" program to wake the system in sleep mode when a condition is met. Typically, the trigger is some function that's named something along the lines of ... "kick the watchdog." I think in this case, Travis just needed a good kick. 😆 @hsanson , we're good to go!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go.
Summary
In response to the bug reported by @cjappl, submitting a fix to resolve Issue #3256.
Changes
.astylerc
when placed along a cpp source file..astylerc
anddummy.cpp
to support the test case.Closes Issue #3256