Fix handling of ranges at file end.

[dfn-certling]

Something along these lines solves the range ending at the file end in my case

[AlxHnr]

I've run into the same issue and can confirm it. Using your fix however leads to ALE breaking my code after renaming a variable with clangd. Here is what happens if I try to to rename setValue to setValue123:

Before:

void Bar::setValue(int value) {
  this->value = value;
}

After:

void Bar::setValue123(int value) { s->value = value; 

The new code is missing } and this gets replaced with s.

Edit: See #3322

[w0rp]

@AlxHnr Can you propose another patch on top of this, and attach the output of ch_logfile from Vim so we can add a test case? You have to use Vim for testing it to get a log file, as NeoVim doesn't offer message logging like Vim does.

[AlxHnr]

@AlxHnr Can you propose another patch on top of this, and attach the output of ch_logfile from Vim

No.

I assume this PR will already fix this issue. The file scrambling problem is a different one, described in #3322. I've posted a more detailed, reproducible example there.

[w0rp]

Okay, I asked for the information I'll need in that issue.

This patch can be merged once there's a test that covers this. Have a look at the test cases, or I'll do it myself at some point. (Could be weeks away from now. It's just whenever I have some spare time.)

[dfn-certling]

I'm puzzled. Looking through the tests

ale/test/test_code_action.vader

Line 179 in 08295ce

Execute(End of file can be modified):

seems to directly test this. And indeed, in my setup this test already fails without my changes. To be more precise, I didn't run the test suite but did what the test essentially does:

1. Create a file with the content described in the test
2. Call ale#code_action#HandleCodeAction with the parameters from the test

So either this test already fails or there is something else at work.

[stale]

This pull request has been automatically marked as stale because it has not been updated recently. Make sure to write tests and document your changes. See :help ale-dev for information on writing tests.
If your pull request is good to merge, bother w0rp or another maintainer again, and get them to merge it.

[w0rp]

I think this has been fixed in a different way according to recent changes. Let me know if you still have any issues.

[w0rp]

Apparently this is still needed, so I'll just merge it.

Cheers! 🍻