Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add intelephense support for php #3357

Merged
merged 3 commits into from
Nov 21, 2020

Conversation

creativenull
Copy link
Contributor

This PR will add initial support for intelephense for PHP.

I've added some tests to go with it. I've never done vim tests with vader before so I took inspiration from the tests implemented from test/command_callback/test_php_langserver_callbacks.vader file.

For the config options, I'm not too sure how I can check if initialization_options were properly read by intelephense. But I have only one test case for that, if someone knows how to do this I won't mind updating this PR with it.

@stale
Copy link

stale bot commented Oct 15, 2020

This pull request has been automatically marked as stale because it has not been updated recently. Make sure to write tests and document your changes. See :help ale-dev for information on writing tests.
If your pull request is good to merge, bother w0rp or another maintainer again, and get them to merge it.

@stale stale bot added the stale PRs a bot will close automatically label Oct 15, 2020
@creativenull
Copy link
Contributor Author

@w0rp @hsanson or any other maintainer out there to take a look at this? All checks are passed, I have couple tests added, unless more is needed.

@stale stale bot closed this Oct 22, 2020
@w0rp w0rp reopened this Nov 21, 2020
@stale stale bot removed the stale PRs a bot will close automatically label Nov 21, 2020
@w0rp w0rp merged commit e4bfcb4 into dense-analysis:master Nov 21, 2020
@w0rp
Copy link
Member

w0rp commented Nov 21, 2020

Cheers! 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants