bibclean: update matchlist reges for bibclean > v2.11.4 #3367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsanson
requested changes
Sep 26, 2020
|
Applied the requested changes. I thought I ran the tests before, but that was a PR to another project, sorry. Added another test case for bibclean > v2.11.4. Additionally, I made the matchlist regex for the legacy version more explicit, so it only matches line numbers and does not break if a colon is included in the message. In the test for the legacy version, I used a message that does actually only exist in newer versions, because I did not know a legacy message that includes colons on the top of my head. |
hsanson
approved these changes
Sep 28, 2020
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3366
Legacy message pattern is still supported, as distributions like debian still package bibclean v2.11.4 from 2015. The legacy support could be removed in the future.