Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use stdin/stdout to communicate with gofmt #3381

Merged
merged 1 commit into from
Nov 29, 2020

Conversation

andreypopp
Copy link
Contributor

Problem: I use docker based workflow where all devtools including gofmt are inside a container. The vim is running on host system though and runs gofmt via a wrapper script which does docker exec gofmt. Because currently fixer uses temp files gofmt cannot see those files produced on the host system.

Solution: use stdin/stdout to communicate with gofmt

I might be missing something why it's not using stdin/stdout currently.

cc @aliou @eliath as contributors to this fixer

@stale
Copy link

stale bot commented Oct 31, 2020

This pull request has been automatically marked as stale because it has not been updated recently. Make sure to write tests and document your changes. See :help ale-dev for information on writing tests.
If your pull request is good to merge, bother w0rp or another maintainer again, and get them to merge it.

@stale stale bot added the stale PRs a bot will close automatically label Oct 31, 2020
@andreypopp
Copy link
Contributor Author

@w0rp hi, can you take a look 👀?

@stale stale bot removed the stale PRs a bot will close automatically label Oct 31, 2020
@stale
Copy link

stale bot commented Nov 28, 2020

This pull request has been automatically marked as stale because it has not been updated recently. Make sure to write tests and document your changes. See :help ale-dev for information on writing tests.
If your pull request is good to merge, bother w0rp or another maintainer again, and get them to merge it.

@stale stale bot added the stale PRs a bot will close automatically label Nov 28, 2020
@andreypopp
Copy link
Contributor Author

Not stale!

@stale stale bot removed the stale PRs a bot will close automatically label Nov 28, 2020
Copy link
Contributor

@hsanson hsanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple and works fine with my limited testing on some small go projects. Probably gofmt did not support stdin/stdout before and that is why ALE did not use it this way.

@hsanson hsanson merged commit 03b6978 into dense-analysis:master Nov 29, 2020
@andreypopp andreypopp deleted the gofmt-stding-stdout branch November 29, 2020 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants