Use stdin/stdout to communicate with gofmt #3381
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: I use docker based workflow where all devtools including
gofmt
are inside a container. The vim is running on host system though and runsgofmt
via a wrapper script which doesdocker exec gofmt
. Because currently fixer uses temp filesgofmt
cannot see those files produced on the host system.Solution: use stdin/stdout to communicate with
gofmt
I might be missing something why it's not using stdin/stdout currently.
cc @aliou @eliath as contributors to this fixer