Make isort fixer recognize auto_pipenv flag #3386
Conversation
There was a problem hiding this comment.
I'd love to see this! It appears that the PR adding similar function for black simply removed that section: https://github.com/dense-analysis/ale/pull/1988/files#diff-b9a6cf2d19edcb105ed741db26eed8b09f0be5348801b806e9dca68050255756L15-L17.
autoload/ale/fixers/isort.vim
Outdated
|
|
||
| if !executable(l:executable) | ||
| if !executable(l:executable) && l:executable != 'pipenv' |
There was a problem hiding this comment.
The current CI failure is complaining about != here: autoload/ale/fixers/isort.vim:27:50: Use robust operators !=#or!=?instead of!= (see Google VimScript Style Guide (Matching))
There was a problem hiding this comment.
Looks like it also wanted isnot in place of !=, more robust when one of the operands isn't a string
|
@crimsonknave Sorry for the massive delay here, took me a while to re-acquaint myself with whatever I was doing here. Tests are fixed and it works for me locally, let me know if anything else needs doing. Thanks! |
|
@ivorpeles Thanks for fixing it up! I'm just a user of ALE, so I have no real idea what else if anything you need to do. I was just looking forward to this getting merged and took a look at what the black plugin did to see if I could help get it unstuck. |
|
Oh cheers, thanks! |
|
@w0rp didn't see anything in the contributing docs about review process, could I get a review on this? |
|
@hsanson bumping for review, this has been open + passing tests for a while. Would be nice to get it merged |
I noticed with
python_auto_pipenv = 1theblackfixer would run on any file in a project containing a Pipfile whether vim was run inside the virtual environment or not. I wanted to makeisort's fixer behave the same way in conjunction with thepython_auto_pipenvflag.What I have below generally works although I do have one concern: the
!executable(l:executable)check fails when the executable ends up beingpipenv. I added a hacky workaround to exclude this case but ideally there would be a test fixture that makesexecutable(pipenv)evaluate as true. We would expect this for any user settingpython_auto_pipenvorpython_isort_auto_pipenvto 1.Would appreciate some feedback here, thanks!