Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

suggest scalafmt for sbt #3399

Merged
merged 1 commit into from
Jan 13, 2021
Merged

suggest scalafmt for sbt #3399

merged 1 commit into from
Jan 13, 2021

Conversation

StephenWithPH
Copy link
Contributor

@StephenWithPH StephenWithPH commented Oct 16, 2020 •
edited

This PR adds sbt as a suggested filetype for the scalafmt fixer.

(cc @zoonfafer)

@StephenWithPH StephenWithPH marked this pull request as ready for review October 19, 2020 16:58
zoonfafer
zoonfafer approved these changes Oct 19, 2020
View reviewed changes
Copy link
Contributor

@zoonfafer zoonfafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stale
Copy link

stale bot commented Nov 16, 2020

This pull request has been automatically marked as stale because it has not been updated recently. Make sure to write tests and document your changes. See :help ale-dev for information on writing tests.
If your pull request is good to merge, bother w0rp or another maintainer again, and get them to merge it.

@stale stale bot added the stale PRs a bot will close automatically label Nov 16, 2020
@StephenWithPH
Copy link
Contributor Author

@w0rp .. bumping this PR to see if you'll accept it

@stale stale bot removed the stale PRs a bot will close automatically label Nov 16, 2020
@stale
Copy link

stale bot commented Dec 14, 2020

This pull request has been automatically marked as stale because it has not been updated recently. Make sure to write tests and document your changes. See :help ale-dev for information on writing tests.
If your pull request is good to merge, bother w0rp or another maintainer again, and get them to merge it.

@stale stale bot added the stale PRs a bot will close automatically label Dec 14, 2020
@StephenWithPH
Copy link
Contributor Author

@w0rp ... bumping again

@stale stale bot removed the stale PRs a bot will close automatically label Dec 14, 2020
@stale
Copy link

stale bot commented Jan 11, 2021

This pull request has been automatically marked as stale because it has not been updated recently. Make sure to write tests and document your changes. See :help ale-dev for information on writing tests.
If your pull request is good to merge, bother w0rp or another maintainer again, and get them to merge it.

@stale stale bot added the stale PRs a bot will close automatically label Jan 11, 2021
@StephenWithPH
Copy link
Contributor Author

@w0rp ... bumping to counter stalebot 🤖

@stale stale bot removed the stale PRs a bot will close automatically label Jan 11, 2021
hsanson
hsanson approved these changes Jan 13, 2021
View reviewed changes
Copy link
Contributor

@hsanson hsanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@hsanson hsanson merged commit 12d28ca into dense-analysis:master Jan 13, 2021
@hsanson
Copy link
Contributor

hsanson commented Jan 13, 2021

@StephenWithPH thanks, persistence is key.

@StephenWithPH StephenWithPH deleted the suggest-scalafmt-for-sbt branch January 13, 2021 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zoonfafer zoonfafer zoonfafer approved these changes

@hsanson hsanson hsanson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@StephenWithPH @hsanson @zoonfafer