Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom erlang/dialyzer options #3425

Merged
merged 6 commits into from
Jan 27, 2021
Merged

Custom erlang/dialyzer options #3425

merged 6 commits into from
Jan 27, 2021

Conversation

pinicarus
Copy link
Contributor

Add an option to specify command line options for the Erlang dialyzer linter.

@pinicarus
Copy link
Contributor Author

Hi,

Do I need to change something else or do you think this PR is OK for merging ?

Thanks a lot.

@stale
Copy link

stale bot commented Dec 5, 2020

This pull request has been automatically marked as stale because it has not been updated recently. Make sure to write tests and document your changes. See :help ale-dev for information on writing tests.
If your pull request is good to merge, bother w0rp or another maintainer again, and get them to merge it.

@stale stale bot added the stale PRs a bot will close automatically label Dec 5, 2020
@pinicarus
Copy link
Contributor Author

Hi @w0rp, any chance to get this PR merged ?

@stale stale bot removed the stale PRs a bot will close automatically label Dec 6, 2020
@stale
Copy link

stale bot commented Jan 3, 2021

This pull request has been automatically marked as stale because it has not been updated recently. Make sure to write tests and document your changes. See :help ale-dev for information on writing tests.
If your pull request is good to merge, bother w0rp or another maintainer again, and get them to merge it.

@stale stale bot added the stale PRs a bot will close automatically label Jan 3, 2021
@kivra-timtip
Copy link

A very welcome feature that I forked. What needs to be done to get it merged?

@stale stale bot removed the stale PRs a bot will close automatically label Jan 8, 2021
@pinicarus
Copy link
Contributor Author

Hi @hsanson,

Can you please check this PR ?

Thanks a lot.

doc/ale-erlang.txt Outdated Show resolved Hide resolved
hsanson
hsanson previously approved these changes Jan 20, 2021
Copy link
Contributor

@hsanson hsanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge after #3548 gets solved.

@hsanson
Copy link
Contributor

hsanson commented Jan 22, 2021

ALE migrated from Travis to Github Actions (see #3548) so it is necessary to rebase this PR from latest master branch to trigger the required checks.

# Add dense-analysis as remote upstream on your local fork. Not 
# needed if already added.
git remote add upstream https://github.com/dense-analysis/ale.git

# Sync your local master with upstream master
git checkout master
git fetch upstream master
git merge upstream/master

# Rebase the PR branch with master
git checkout my-branch-name
git rebase master   # Fix any conflicts you may have

# Force push the updated PR branch to origin to trigger the checks
git push -f origin my-branch-name

Signed-off-by: Pierre-Nicolas Clauss <pinicarus@protonmail.com>
Signed-off-by: Pierre-Nicolas Clauss <pinicarus@protonmail.com>
@pinicarus
Copy link
Contributor Author

@hsanson : branch has been rebased, all tests are green ;)

Copy link
Contributor

@hsanson hsanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patience. Good to merge.

@hsanson hsanson merged commit c9f4005 into dense-analysis:master Jan 27, 2021
@pinicarus pinicarus deleted the custom-dialyzer-options branch January 30, 2021 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants