Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adds variable to use custom config file with Elixir Credo #3455

Merged
merged 5 commits into from
Jan 19, 2021

Conversation

Thau
Copy link

@Thau Thau commented Nov 23, 2020

Reopened version of #3331 because stale-bot closed it, including @w0rp's suggestions.

Adds g:ale_elixir_credo_config_file to allow users to use a custom configuration file for the checks. Motivation is my company using a centralised configuration file for all of our Elixir projects, so it's our belief that more people could benefit from this option.

Thank you!

@stale
Copy link

stale bot commented Dec 21, 2020

This pull request has been automatically marked as stale because it has not been updated recently. Make sure to write tests and document your changes. See :help ale-dev for information on writing tests.
If your pull request is good to merge, bother w0rp or another maintainer again, and get them to merge it.

@stale stale bot added the stale PRs a bot will close automatically label Dec 21, 2020
@Thau
Copy link
Author

Thau commented Dec 21, 2020

@w0rp ?

@stale stale bot removed the stale PRs a bot will close automatically label Dec 21, 2020
@stale
Copy link

stale bot commented Jan 18, 2021

This pull request has been automatically marked as stale because it has not been updated recently. Make sure to write tests and document your changes. See :help ale-dev for information on writing tests.
If your pull request is good to merge, bother w0rp or another maintainer again, and get them to merge it.

@stale stale bot added the stale PRs a bot will close automatically label Jan 18, 2021
@Thau
Copy link
Author

Thau commented Jan 18, 2021

Still ready to merge, stalebot :P

@stale stale bot removed the stale PRs a bot will close automatically label Jan 18, 2021
Copy link
Contributor

@hsanson hsanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for waiting... looks good to me.

@hsanson hsanson merged commit bfc412a into dense-analysis:master Jan 19, 2021
@Thau
Copy link
Author

Thau commented Jan 20, 2021

@hsanson, no worries, I understand you guys have quite some PRs to watch for. It's been a pleasure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants