-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow duplicate LSP completions for autoimport #3473
Allow duplicate LSP completions for autoimport #3473
Conversation
This pull request has been automatically marked as stale because it has not been updated recently. Make sure to write tests and document your changes. See |
Hi @w0rp - happy New Year! Sorry to bother you, this was just automatically market as stale, but I'd like to have this merged since I use this a lot. Is there something that needs fixing before it's merged? |
ALE migrated from Travis to Github Actions (see #3548) so it is necessary to rebase this PR from latest master branch to trigger the required checks.
|
d5055ba
to
7403318
Compare
Similarly to TS completions, this allows the user to pick the package to autoimport when both the package and method name are the same.
@hsanson thanks for the info - just rebased and all the tests have passed. Are there any blockers for merging this? It was a pretty simple change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Cheers! 🍻 |
Thank you! |
Similarly to TS completions, this allows the user to pick the package to autoimport when both the package and method name are the same.
See the screenshot below for example:
Previously only a single
errors.New
method would be visible.