Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow duplicate LSP completions for autoimport #3473

Conversation

jeremija
Copy link
Contributor

Similarly to TS completions, this allows the user to pick the package to autoimport when both the package and method name are the same.

See the screenshot below for example:

image

Previously only a single errors.New method would be visible.

@stale
Copy link

stale bot commented Jan 3, 2021

This pull request has been automatically marked as stale because it has not been updated recently. Make sure to write tests and document your changes. See :help ale-dev for information on writing tests.
If your pull request is good to merge, bother w0rp or another maintainer again, and get them to merge it.

@stale stale bot added the stale PRs a bot will close automatically label Jan 3, 2021
@jeremija
Copy link
Contributor Author

jeremija commented Jan 3, 2021

Hi @w0rp - happy New Year! Sorry to bother you, this was just automatically market as stale, but I'd like to have this merged since I use this a lot. Is there something that needs fixing before it's merged?

@stale stale bot removed the stale PRs a bot will close automatically label Jan 3, 2021
@hsanson
Copy link
Contributor

hsanson commented Jan 22, 2021

ALE migrated from Travis to Github Actions (see #3548) so it is necessary to rebase this PR from latest master branch to trigger the required checks.

# Add dense-analysis as remote upstream on your local fork. Not 
# needed if already added.
git remote add upstream https://github.com/dense-analysis/ale.git

# Sync your local master with upstream master
git checkout master
git fetch upstream master
git merge upstream/master

# Rebase the PR branch with master
git checkout my-branch-name
git rebase master   # Fix any conflicts you may have

# Force push the updated PR branch to origin to trigger the checks
git push -f origin my-branch-name

@jeremija jeremija force-pushed the allow-duplicate-lsp-completions-for-autoimport branch from d5055ba to 7403318 Compare January 30, 2021 07:55
Similarly to TS completions, this allows the user to pick the package to
autoimport when both the package and method name are the same.
@jeremija
Copy link
Contributor Author

@hsanson thanks for the info - just rebased and all the tests have passed. Are there any blockers for merging this? It was a pretty simple change.

Copy link
Member

@w0rp w0rp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@w0rp w0rp merged commit e8080be into dense-analysis:master Jan 31, 2021
@w0rp
Copy link
Member

w0rp commented Jan 31, 2021

Cheers! 🍻

@jeremija
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants