-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Stoplight Spectral linter for yaml #3489
Conversation
t2h5
commented
Dec 14, 2020
•
edited
edited
- Add Stoplight Spectral linter for yaml and json.
- https://github.com/stoplightio/spectral
- It helps to edit OpenAPI Schema.
3ccdf62
to
fac4f04
Compare
fac4f04
to
e136018
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This linter is very useful, did not know about it. Would be great if this PR also added support for JSON files. It should not be difficult to achieve.
Check for example redpen linter that supports many file types: markdown, rst, tex, text, etc. All methods used by the linter are defined in autoload/ale/handlers/redpen.vim
and then only the linter definitions are in the respective file type paths: ale_linters/text/redpen.vim
, ale_linters/markdown/redpen.vim
, etc.
Added JSON support. |
c29bf56
to
2187ea1
Compare
@w0rp seems travis CI is somehow stuck... may PRs are waiting for status report and cannot be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes are good and tested the linter works properly on my own openapi yaml and json definitions.
ALE migrated from Travis to Github Actions (see #3548) so it is necessary to rebase this PR from latest master branch to trigger the required checks.
|
60c66ff
to
66b3e76
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go, thanks.