Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

phan: add filename to output #3529

Merged
merged 1 commit into from
Feb 5, 2021
Merged

phan: add filename to output #3529

merged 1 commit into from
Feb 5, 2021

Conversation

krsch
Copy link
Contributor

@krsch krsch commented Jan 8, 2021

Without this fix phan shows errors for all repo in the current file so that every line contains errors from all files.
There were no tests for phan-client and I didn't add one.

@krsch krsch changed the title add filename to output phan: add filename to output Jan 8, 2021
@hsanson
Copy link
Contributor

hsanson commented Jan 22, 2021

ALE migrated from Travis to Github Actions (see #3548) so it is necessary to rebase this PR from latest master branch to trigger the required checks.

# Add dense-analysis as remote upstream on your local fork. Not 
# needed if already added.
git remote add upstream https://github.com/dense-analysis/ale.git

# Sync your local master with upstream master
git checkout master
git fetch upstream master
git merge upstream/master

# Rebase the PR branch with master
git checkout my-branch-name
git rebase master   # Fix any conflicts you may have

# Force push the updated PR branch to origin to trigger the checks
git push -f origin my-branch-name

@krsch
Copy link
Contributor Author

krsch commented Feb 3, 2021

updated

Copy link
Contributor

@hsanson hsanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@hsanson hsanson merged commit 787ab2a into dense-analysis:master Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants