Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deno support for LSP and fixer #3533

Merged
merged 4 commits into from
Jan 23, 2021
Merged

Conversation

motato1
Copy link
Contributor

@motato1 motato1 commented Jan 11, 2021

Deno is a JavaScript and TypeScript runtime akin to Node, however it does not use Node packages/npm.
As of version 1.6.0, Deno brings its own Language Server implementation, though it is not yet feature-complete (see denoland/deno#8643).

This PR integrates Deno LSP support as well as the built-in fixer (deno fmt) into ALE (TypeScript only).

Currently, no version check is performed to see if LSP is supported (although I mention the required version in the help file).
If that is a requirement, please let me know. Also, a pointer to an example of how version checks are usually performed in ALE would be helpful.

@motato1 motato1 marked this pull request as ready for review January 11, 2021 22:05
@hsanson
Copy link
Contributor

hsanson commented Jan 22, 2021

ALE migrated from Travis to Github Actions (see #3548) so it is necessary to rebase this PR from latest master branch to trigger the required checks.

# Add dense-analysis as remote upstream on your local fork. Not 
# needed if already added.
git remote add upstream https://github.com/dense-analysis/ale.git

# Sync your local master with upstream master
git checkout master
git fetch upstream master
git merge upstream/master

# Rebase the PR branch with master
git checkout my-branch-name
git rebase master   # Fix any conflicts you may have

# Force push the updated PR branch to origin to trigger the checks
git push -f origin my-branch-name

@motato1
Copy link
Contributor Author

motato1 commented Jan 22, 2021

Thank you.
I rebased my branch onto upstream master and fixed the documentation to satisfy the linters.

Copy link
Contributor

@hsanson hsanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants