Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rnix-lsp for Nix diagnostics and completion #3556

Merged
merged 1 commit into from
Jan 23, 2021
Merged

Add rnix-lsp for Nix diagnostics and completion #3556

merged 1 commit into from
Jan 23, 2021

Conversation

jD91mZM2
Copy link
Contributor

No description provided.

hsanson
hsanson requested changes Jan 22, 2021
View reviewed changes
Copy link
Contributor

@hsanson hsanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also include respective documentation changes and add some tests. Check these PRs as examples:

@jD91mZM2
Copy link
Contributor Author

There, is that better? :)

hsanson
hsanson reviewed Jan 23, 2021
View reviewed changes
test/nix/test.nix Outdated Show resolved Hide resolved
hsanson
hsanson previously approved these changes Jan 23, 2021
View reviewed changes
hsanson
hsanson approved these changes Jan 23, 2021
View reviewed changes
Copy link
Contributor

@hsanson hsanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go. Thanks or the work.

@hsanson hsanson merged commit 9fd9435 into dense-analysis:master Jan 23, 2021
@jD91mZM2 jD91mZM2 deleted the rnix branch January 23, 2021 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsanson hsanson hsanson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jD91mZM2 @hsanson