Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ocamllsp #3595

Merged
merged 3 commits into from
Feb 18, 2021
Merged

Added ocamllsp #3595

merged 3 commits into from
Feb 18, 2021

Conversation

Risto-Stevcev
Copy link
Contributor

@Risto-Stevcev Risto-Stevcev commented Feb 18, 2021

This adds the new official OCaml language server (ols is archived)

@Risto-Stevcev
Copy link
Contributor Author

The linters test fails but I'm not sure what's going on and what needs to be done there:

========================================                                                                                                                                      
Checking for invalid tag references                                                    
========================================                                                                                                                                      
Invalid tag references tags follow:                                                    
                                                                                       
========================================                                               
diff supported-tools.md and doc/ale-supported-languages-and-tools.txt tables           
========================================                                               
Differences follow:                                                                                                                                                           
                                                                                                                                                                              
--- /tmp/doc-sorted.XXFaDlBG                                                           
+++ /tmp/doc.XXFolFPC                                                                  
@@ -245 +244,0 @@                                                                      
-OCaml - ocamllsp                                                                      
@@ -246,0 +246 @@                                                                      
+OCaml - ocamllsp                                                                      
                                                                                       
The supported tools list isn't sorted properly           

@hsanson
Copy link
Contributor

hsanson commented Feb 18, 2021

@Risto-Stevcev make sure that "ocamllsp" is listed before "ocp-indent" everywhere they are listed so they are sorted in alphabetical order:

   * [merlin](https://github.com/the-lambda-church/merlin)
   * [ocamlformat](https://github.com/ocaml-ppx/ocamlformat)
   * [ocamllsp](https://github.com/ocaml/ocaml-lsp)      
   * [ocp-indent](https://github.com/OCamlPro/ocp-indent)                                                                                                      
  * [ols](https://github.com/freebroccolo/ocaml-language-server)

This order must be the same on these files:

  • ale.txt
  • ale-supported-languages-and-tools.txt
  • supported-tools.md

Not 100% sure about this one but for consistency also ale-ocaml.txt.

If you have docker daemon running on your machine you can run the linter-only tests locally to check if everything is ok before pushing your changes to Github:

./run-tests --linters-only

@Risto-Stevcev
Copy link
Contributor Author

Ah thanks, all the checks are passing now

Copy link
Contributor

@hsanson hsanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the addition.

@hsanson hsanson merged commit 3ea887d into dense-analysis:master Feb 18, 2021
@hsanson hsanson mentioned this pull request Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants