fix(eslint): yarn 2 project cwd

[shannonmoeller]

Improves logic around detecting a project root based on the presence of eslint in node_modules or .yarn/sdks. Helps with, but still not a complete fix for #2970.

[shannonmoeller]

This line was causing the CWD to be set to /path/to/project/.yarn/sdks/eslint/bin/eslint. instead of /path/to/project which made the command fail as eslint. doesn't exist and definitely isn't a directory.

(executable check - success) /path/to/project/.yarn/sdks/eslint/bin/eslint.js
(finished - exit code 1) ['/bin/zsh', '-c', 'cd ''/path/to/project/.yarn/sdks/eslint/bin/eslint.'' && ''/path/to/project/.yarn/sdks/eslint/bin/eslint.js'' -f json --stdin --stdin-filename ''/path/to/project/src/some/file.js'' < ''/var/folders/tr/.../file.js''']

[shannonmoeller]

The longest value is the nearer directory.

[shannonmoeller]

Sorry to be noisy, but checking on the status here. I implemented a solution with passing tests. Is there anything else you need from me to get this merged? Thanks.

[w0rp]

Cheers! 🍻

[shannonmoeller]

Thank you!!

[jsit]

@shannonmoeller This doesn't seem to be working for me. I have eslint 8.33.0 installed in a project. When I try to run .yarn/sdks/eslint/bin/eslint.js directly, I get this message:

Error: Missing "./bin/eslint.js" export in "eslint" package

I assume this isn't an issue with your code, but with some change in eslint. Any idea what might fix this? Thanks!

As a workaround I've added this to my vimrc:

if !empty(finddir('.yarn/sdks', ';'))
	let g:ale_javascript_eslint_use_global = 1
	let g:ale_javascript_eslint_executable = 'yarn'
	let g:ale_javascript_eslint_options = 'run eslint'
endif