Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes an index error with Java files. #3706

Merged
merged 2 commits into from Jun 22, 2021
Merged

Conversation

stbraun
Copy link
Contributor

@stbraun stbraun commented Apr 26, 2021

When loading a Java file into Vim an index error occurred in ale_linters#java#javac#Handle. I added empty checks and this resolved the issue for me.
Please be aware that these were the first lines of Vim code I ever wrote. Hopefully I didn't mess it up.

@stale
Copy link

stale bot commented Jun 21, 2021

This pull request has been automatically marked as stale because it has not been updated recently. Make sure to write tests and document your changes. See :help ale-dev for information on writing tests.
If your pull request is good to merge, bother w0rp or another maintainer again, and get them to merge it.

@stale stale bot added the stale PRs a bot will close automatically label Jun 21, 2021
w0rp
w0rp previously approved these changes Jun 22, 2021
@stale stale bot removed the stale PRs a bot will close automatically label Jun 22, 2021
ale_linters/java/javac.vim Outdated Show resolved Hide resolved
@w0rp w0rp merged commit a4ba421 into dense-analysis:master Jun 22, 2021
@w0rp
Copy link
Member

w0rp commented Jun 22, 2021

Cheers! 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants