Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Robot framework rflint support #3715

Merged
merged 2 commits into from
Sep 11, 2021
Merged

Robot framework rflint support #3715

merged 2 commits into from
Sep 11, 2021

Conversation

Cupprum
Copy link
Contributor

@Cupprum Cupprum commented May 5, 2021

Added support for rflint, which is static syntax checker for Robot Framework syntax. Also wrote tests + documentation.

Cupprum and others added 2 commits April 27, 2021 20:40
@Cupprum
Create rflint.vim
2e41036 
support for robot framework by creating ale definition for rflint syntax linter
robot framework - rflint support
5f4a9b0
@stale
Copy link

stale bot commented Jul 1, 2021

This pull request has been automatically marked as stale because it has not been updated recently. Make sure to write tests and document your changes. See :help ale-dev for information on writing tests.
If your pull request is good to merge, bother w0rp or another maintainer again, and get them to merge it.

@stale stale bot added the stale PRs/Issues no longer valid label Jul 1, 2021
@hsanson hsanson removed the stale PRs/Issues no longer valid label Jul 3, 2021
@Cupprum
Copy link
Contributor Author

Cupprum commented Jul 8, 2021

@w0rp Please can you review my PR? It adds support for rflint. Let me know if there is anything more i can do.

@hsanson hsanson closed this Jul 9, 2021
@hsanson hsanson reopened this Jul 9, 2021
@stale
Copy link

stale bot commented Sep 3, 2021

This pull request has been automatically marked as stale because it has not been updated recently. Make sure to write tests and document your changes. See :help ale-dev for information on writing tests.
If your pull request is good to merge, bother w0rp or another maintainer again, and get them to merge it.

@stale stale bot added the stale PRs/Issues no longer valid label Sep 3, 2021
@stale stale bot closed this Sep 10, 2021
@Cupprum
Copy link
Contributor Author

Cupprum commented Sep 10, 2021

@hsanson @w0rp Is there anything more what needs to be done in order for this PR to be merged? Tests and Documentation have been written in the way which Ale documentation dictates.

@hsanson hsanson reopened this Sep 10, 2021
@stale stale bot removed the stale PRs/Issues no longer valid label Sep 10, 2021
hsanson
hsanson approved these changes Sep 11, 2021
View reviewed changes
Copy link
Contributor

@hsanson hsanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for the reminder.

@hsanson hsanson merged commit 19437e2 into dense-analysis:master Sep 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsanson hsanson hsanson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Cupprum @hsanson