Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ALEPopulateQuickfix and ALEPopulateLocList #3761

Merged
merged 2 commits into from
Feb 4, 2022

Conversation

idbrii
Copy link
Contributor

@idbrii idbrii commented Jun 8, 2021

Resolve #1810.

Add ALEPopulateQuickfix and ALEPopulateLocList. They're not very useful
with ale's default autopopulate behaviour, so their useful configuration
is described in help.

Also fixed an unrelated typo.

Open to changing the command names. I'd suggested ALEShowErrors, but since there's two lists I went with populate. Not sure if it should optionally obey g:ale_open_list. That setting seems mostly for "don't make windows popup automatically", so I don't have a bang variant.

I didn't implement the fancy list target preservation described on the issue. Doing that would improve this feature to keep the list updated while it's displayed, but it seems much more complicated.

@idbrii
Copy link
Contributor Author

idbrii commented Jun 8, 2021

CI failed with:

Ran 5 tests in 0.001s

OK

Something went wrong!
Error: Process completed with exit code 1.

I don't understand how to resolve that or find more info. Maybe it's flakey?

I didn't see the "Custom warnings/errors follow". Fixed.

@idbrii
Copy link
Contributor Author

idbrii commented Jun 11, 2021

Fixed trailing whitespace and made test more comprehensive.

@idbrii idbrii force-pushed the add-showerrors branch 3 times, most recently from 0bd258a to ceeb7dd Compare June 11, 2021 18:57
Resolve dense-analysis#1810.

Add ALEPopulateQuickfix and ALEPopulateLocList. They're not very useful
with ale's default autopopulate behaviour, so their useful configuration
is described in help.

Test is based on test_ale_lint_command.vader

Manual Test
* configure as described in doc
* open a file with lint errors
* use scriptease's Vedit to populate loc-list
* modify and save file - loc-list is preserved
* ALEPopulateQuickfix - quickfix is opened with lint
* ALEPopulateLocList - loc-list is replaced with lint
@stale
Copy link

stale bot commented Aug 7, 2021

This pull request has been automatically marked as stale because it has not been updated recently. Make sure to write tests and document your changes. See :help ale-dev for information on writing tests.
If your pull request is good to merge, bother w0rp or another maintainer again, and get them to merge it.

@stale stale bot added the stale PRs a bot will close automatically label Aug 7, 2021
@idbrii
Copy link
Contributor Author

idbrii commented Aug 7, 2021

@w0rp: I've been using this feature since I implemented it and enjoying it. I have tests and it's working well. Could I get a review? Do you want me to rebase on master first?

@stale stale bot removed the stale PRs a bot will close automatically label Aug 7, 2021
@idbrii
Copy link
Contributor Author

idbrii commented Aug 9, 2021

Got another user (on #2866) to confirm this PR works for them too.

@stale
Copy link

stale bot commented Oct 4, 2021

This pull request has been automatically marked as stale because it has not been updated recently. Make sure to write tests and document your changes. See :help ale-dev for information on writing tests.
If your pull request is good to merge, bother w0rp or another maintainer again, and get them to merge it.

@stale stale bot added the stale PRs a bot will close automatically label Oct 4, 2021
@idbrii
Copy link
Contributor Author

idbrii commented Oct 6, 2021

I'm using this regularly.

I don't love how ALEPopulateQuickfix populates for all open files, but ALEPopulateLocList is very useful.

@stale stale bot removed the stale PRs a bot will close automatically label Oct 6, 2021
@stale
Copy link

stale bot commented Dec 2, 2021

This pull request has been automatically marked as stale because it has not been updated recently. Make sure to write tests and document your changes. See :help ale-dev for information on writing tests.
If your pull request is good to merge, bother w0rp or another maintainer again, and get them to merge it.

@stale stale bot added the stale PRs a bot will close automatically label Dec 2, 2021
@idbrii
Copy link
Contributor Author

idbrii commented Dec 2, 2021

@w0rp Still love to get this reviewed and merged. It has tests and documentation.

@stale stale bot removed the stale PRs a bot will close automatically label Dec 2, 2021
@stale
Copy link

stale bot commented Jan 28, 2022

This pull request has been automatically marked as stale because it has not been updated recently. Make sure to write tests and document your changes. See :help ale-dev for information on writing tests.
If your pull request is good to merge, bother w0rp or another maintainer again, and get them to merge it.

@stale stale bot added the stale PRs a bot will close automatically label Jan 28, 2022
@idbrii
Copy link
Contributor Author

idbrii commented Feb 1, 2022

Bump to unstale.

@stale stale bot removed the stale PRs a bot will close automatically label Feb 1, 2022
Copy link
Member

@w0rp w0rp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like pretty much what I described years ago. I'll merge this.

@w0rp w0rp merged commit 5856c06 into dense-analysis:master Feb 4, 2022
@w0rp
Copy link
Member

w0rp commented Feb 4, 2022

Cheers! 🍻

Sorry for not being very active these days. I check random things now and then and I don't have much to add to ALE myself for the moment as it does everything I want it to do for now.

@idbrii idbrii deleted the add-showerrors branch February 4, 2022 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add commands for populating the loclist or quickfix list with errors from the buffer
2 participants