Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for dart format fixer #3764

Merged
merged 1 commit into from
Jul 16, 2021
Merged

Conversation

ghsang
Copy link
Contributor

@ghsang ghsang commented Jun 13, 2021

dartfmt is being deprecated in favor of dart format. (dart-lang/dart_style#986)

Code was adapted from dartfmt fixer (#1683)

@ghsang ghsang force-pushed the master branch 2 times, most recently from 70f8405 to b11266e Compare June 13, 2021 10:44
Copy link
Contributor

@hsanson hsanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests need to be fixed.

@ghsang
Copy link
Contributor Author

ghsang commented Jul 16, 2021

Sorry, it has been fixed to pass ./run-tests.

@ghsang ghsang requested a review from hsanson July 16, 2021 04:25
Copy link
Contributor

@hsanson hsanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good.

@hsanson hsanson merged commit d6dbb53 into dense-analysis:master Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants