Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

racket: support racket-langserver lsp #3808

Merged
merged 9 commits into from
Jul 20, 2021

Conversation

benknoble
Copy link
Contributor

Not sure what tests are reasonable for an LSP linter. This worked for me after raco pkg install racket-langserver.

Notably, before I did that, the LSP didn't work (obviously), but I could see no error messages; only "executable check—success" for racket.

@benknoble
Copy link
Contributor Author

/cc @hsanson now that tests are passing.

@hsanson
Copy link
Contributor

hsanson commented Jul 17, 2021

Check ruby solargraph and eclipselsp test for example on how to write tests for a language server. In short:

  1. Create directory and files that simulate a racket project in test-files. From what I see a racket project must have a init.rkt file, also I see it looks for the top most one so to test this you can create a directory tree with init.rkt files and test that the linter detects the correct project dir with AssertLSPProject.
  2. Use AssertLSPLanguage, AssertLSPConfig, AssertLSPOptions, and AssertLinter to check that things are properly set.

@benknoble
Copy link
Contributor Author

@hsanson done

Copy link
Contributor

@hsanson hsanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes.

@hsanson hsanson merged commit 651038b into dense-analysis:master Jul 20, 2021
@benknoble benknoble deleted the racket-langserver branch October 4, 2023 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants