Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update erlang format for OTP24 #3823

Merged
merged 1 commit into from
Jul 17, 2021
Merged

Update erlang format for OTP24 #3823

merged 1 commit into from
Jul 17, 2021

Conversation

Kuroneer
Copy link
Contributor

Erlang's erlc error format includes the column in OTP24.
See https://blog.erlang.org/My-OTP-24-Highlights/#column-number-in-warnings-and-errors

hsanson
hsanson approved these changes Jul 17, 2021
View reviewed changes
Copy link
Contributor

@hsanson hsanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, adds support for new format without breaking previous one and tests both. Thanks for the contribution.

@hsanson hsanson merged commit a6a8131 into dense-analysis:master Jul 17, 2021
@Kuroneer
Copy link
Contributor Author

Cheers! 🍻 :)

@Kuroneer Kuroneer deleted the erlc-otp24 branch July 18, 2021 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsanson hsanson hsanson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Kuroneer @hsanson