Adds fixer for golines #3862
Merged
Adds fixer for golines #3862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsanson
requested changes
Aug 7, 2021
hsanson
reviewed
Aug 7, 2021
hsanson
reviewed
Aug 8, 2021
| @@ -183,6 +183,7 @@ Notes: | |||
| * `goimports` | |||
| * `golangci-lint`!! | |||
| * `golangserver` | |||
| * golines | |||
There was a problem hiding this comment.
This one took me a while to figure out. The indentation should be using spaces instead of tabs and is missing the backticks `golines`
There was a problem hiding this comment.
My bad, for some reason vim was hiding the backticks around the other tool names and I didn't know they were required.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a fixer for "golines" (https://github.com/segmentio/golines) , a tool that automatically wraps long lines in go files.
Based on the goimport and gofmt fixer/tests :)