Do not show linebreaks in virtual text warnings #3949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vimpostor
force-pushed
the
virt_multiline
branch
from
3bc2999
to
cd36ed1
Compare
Before this patch multiline warnings would appear in a single line with '^@' as separator. Now we use whitespace as separator to improve the appearance. Also strip trailing whitespace, newlines, etc... Fixes dense-analysis#3939
vimpostor
force-pushed
the
virt_multiline
branch
from
cd36ed1
to
12191dd
Compare
vimpostor
changed the title
hsanson
approved these changes
Oct 21, 2021
Did you forget to merge or are we waiting for another approval? |
|
I though I merged this, thanks for the notice. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces all line breaks with whitespace. Before this patch, these line breaks would show up as
'^@'or'^M'- depending on OS, which is kinda ugly. It is better to replace them with whitespace. This also removes trailing whitespace withtrim().