Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite Alex Integration to Use stdin #3982

Merged
merged 1 commit into from
Nov 18, 2021
Merged

Rewrite Alex Integration to Use stdin #3982

merged 1 commit into from
Nov 18, 2021

Conversation

cyntheticfox
Copy link
Contributor

Since having been added, the alex tool has added support for linting
on stdin. Rewrite this integration to reduce the number of tools
requiring disk-write access.

Been sitting on this for a second; waited for alex to be added to nixpkgs.

Closes #3971

Since having been added, the `alex` tool has added support for linting
on stdin. Rewrite this integration to reduce the number of tools
requiring disk-write access.

Signed-off-by: David Houston <houstdav000@gmail.com>
Copy link
Contributor

@hsanson hsanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

The --stdin flag seems to have been added on version 6.0.0 released in 2018 so I think is safe to assume this won't break for people using older versions of alex.

@hsanson hsanson merged commit 2cfeabd into dense-analysis:master Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rewrite alex Integration to Use --stdin
2 participants