Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore checkmake linebreaks #3986

Merged
merged 3 commits into from
Nov 18, 2021
Merged

Restore checkmake linebreaks #3986

merged 3 commits into from
Nov 18, 2021

Conversation

dgeorge83616
Copy link
Contributor

Checkmake maintainers recently removed linebreak from internal formatter. This PR prevents checkmake errors from appearing as a single error.

For more description: see No newlines in ALE output end remove newline for custom formatter.

@dgeorge83616 dgeorge83616 marked this pull request as draft November 16, 2021 23:48
@dgeorge83616 dgeorge83616 marked this pull request as ready for review November 17, 2021 01:00
hsanson
hsanson approved these changes Nov 18, 2021
View reviewed changes
Copy link
Contributor

@hsanson hsanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, look good to me.

@hsanson hsanson merged commit 3ca66e4 into dense-analysis:master Nov 18, 2021
@dgeorge83616 dgeorge83616 deleted the restore_checkmake_linebreaks branch November 18, 2021 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsanson hsanson hsanson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dgeorge83616 @hsanson @danduril