add support for checkov for linting terraform files #4006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When you add new linters or fixers, make sure to add them into the tables in supported-tools.md and ale-supported-languages-and-tools.txt. These files must be sorted properly so ensure the tool is added in the proper alphabetical order. |
hsanson
requested changes
Dec 9, 2021
|
Also add an entry to ale-terraform.txt with the new linter and configuration options. |
|
@hsanson Thank you for the feedback and the explanations! I updated the branch accordingly and hope, it is now ready for being merged. |
|
@thyme-87 sorry, forgot to mention you have to add checkov entry to the list of tools in ale.txt file. Make sure to add it in the same order as in the ale-terraform.txt file. |
hsanson
approved these changes
Dec 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Display rule violations from checkov via
ale. Motivated by checkov2vim which I did not manage to set up correctly on my machine.I provided the most basic tests (derived from the tests for the
terraformlinter andansible_lint) and I do hope that this is sufficient.Please let me know if I missed anything.