Fix crash for Reek 6.0.4 #4010
Merged
Fix crash for Reek 6.0.4 #4010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `let g:ale_ruby_reek_show_wiki_link = 1`, Reek linter is crashed because `wiki_link` attribute does not exist in result. It seems that `wiki_link` is now replaced with `documentation_link` in recent version of Reek
hsanson
approved these changes
Dec 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
let g:ale_ruby_reek_show_wiki_link = 1, Reek linter is crashedbecause
wiki_linkattribute does not exist in result.It seems that
wiki_linkis now replaced withdocumentation_linkinrecent version of Reek
Please help to review this PR, thanks.