Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows to use quickfix for references. #4033

Merged
merged 2 commits into from
Feb 5, 2022
Merged

Allows to use quickfix for references. #4033

merged 2 commits into from
Feb 5, 2022

Conversation

daliusd
Copy link
Contributor

@daliusd daliusd commented Jan 14, 2022

E.g. following mapping could be used to find references for item under
cursor and put result into quickfix list:

nnoremap <leader>af :ALEFindReferences -quickfix<CR>

Fixes #1759

E.g. following mapping could be used to find references for item under
cursor and put result into quickfix list:

```
nnoremap <leader>af :ALEFindReferences -quickfix<CR>
```

Fixes #1759
@daliusd
Copy link
Contributor Author

daliusd commented Jan 14, 2022

@hsanson please review.

Copy link
Contributor

@hsanson hsanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine with my limited testing usin Solargraph LSP. Thanks.

I just would like to have the documention also updated to include the new option :h ALEFindReferences. Also mention that the -relative option has no effect if -quickfix is used.

Finally not sure but maybe would be good to automatically open the quickfix if it is not open?

@daliusd
Copy link
Contributor Author

daliusd commented Feb 4, 2022

Works fine with my limited testing usin Solargraph LSP. Thanks.

Cool. I have tested with tsserver and pyright.

I just would like to have the documention also updated to include the new option :h ALEFindReferences. Also mention that the -relative option has no effect if -quickfix is used.

Documentation updated.

Finally not sure but maybe would be good to automatically open the quickfix if it is not open?

Vim grep command does not open quickfix list by default. I personally never open quickfix list. Here is suggestion how to open quickfix list window for grep command that must work for ALEFindReferences if there is a need: https://www.reddit.com/r/vim/comments/bmh977/comment/emwjm7h/?utm_source=share&utm_medium=web2x&context=3

@daliusd daliusd requested a review from hsanson February 4, 2022 14:10
Copy link
Contributor

@hsanson hsanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for the changes.

@hsanson hsanson merged commit 0c276aa into dense-analysis:master Feb 5, 2022
@daliusd daliusd deleted the find-references-quickfix branch February 5, 2022 16:23
@daliusd
Copy link
Contributor Author

daliusd commented Feb 5, 2022

🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

quickfix list support for ALEFindReferences and commands for navigating through references
2 participants