-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CMake linter cmake-lint #4036
Add CMake linter cmake-lint #4036
Conversation
Since the current linter is unmaintained, wouldn't it make sense to replace it with the new one? |
The old linter has been forked and now lives in cmake-lint/cmake-lint. Development is far from active, but I asked if the project was still maintained and the answer was yes. So I don't think it's fair to replace it really. |
Ah, thank you. I only knew the original repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good. Just missing tests for the linter itself. Can you add one similar to test/linter/test_ruby.vader
? It tests if the correct default command is returned and if the options are properly set if configured.
Add support for the CMake linter provided by https://github.com/cheshirekow/cmake_format.
a52ab62
to
b92fe6e
Compare
b92fe6e
to
ea6ac72
Compare
Added the test and also wrapped the executable in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution.
@carlsmedstad @offa does this new linter replaces the current one available in ALE: Wondering if we should consider removing it. I see from that repo that there has not been any activity in the last 5 years. But that alone is not indiciation that the linter is not being used. |
See my comment above for my opinion about that:
I think we should update the URL to point to the new repository at least (https://github.com/cmake-lint/cmake-lint). |
Add support for the CMake linter cmake-lint provided by https://github.com/cheshirekow/cmake_format.
A bit unsure about the naming due to the conflict with the other linter for CMake.
Resolves #3396.