Treat ale_open_list integer value as a threshold #4050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only open list window if the number of warnings or errors equals to or exceeds the value of ale_open_list. No change when set to `1`.
nospam2998
force-pushed
the
feature/open_list_num
branch
from
a4b2c1b
to
b615f9b
Compare
|
Branch rebased onto current master. |
w0rp
approved these changes
Feb 4, 2022
|
I set it to auto-merge when the checks are completed. |
This was referenced Feb 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting
ale_open_list = 1is great when having multiple lints to address. Yet it is annoying as %#"¤ to use that setting when writing new code, as the window tends to open way too frequently.This change makes this already numeric option possible to set to higher values, and doing so leads to only opening a list window if the number of warnings or errors equals to or exceeds the value. A typical useful value could be
ale_open_list = 2which allows for typing a word to completion without getting a split buffer. One can imagine other thresholds being attractive for other use cases.No change to functionality is intended when
ale_open_listis set to the previously allowed values0,1andon_save.