Add CodeAction codeActionLiteralSupport Feature #4163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, rust-analyzer doesn't return any code actions. With it, everything works properly.
sak96
changed the title
|
Not sure how to raise visibility on this, but this does fix rust-analyzer and doesn't break tests, which is great. Thanks for the improvements on my hasty code. Even though I don't write a ton of Rust, this makes ALE far more useful. The "Implement missing members" action alone is a huge productivity gain. |
|
Yeah I wanted to debug it but i saw that you had already figure it out so i just improved your pr. |
max([value, 1])Without the above With the above |
Special values like for example -1 to denote the end of a line are not supported. [reference](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#position)
hsanson
approved these changes
Apr 29, 2022
cyyever
pushed a commit
to cyyever/ale
that referenced
this pull request
Jul 11, 2022
* Advertise codeActionLiteralSupport to LSP server Without this, rust-analyzer doesn't return any code actions. With it, everything works properly. * linter fixes * test cases fixes * Fix underflow of column in position. Special values like for example -1 to denote the end of a line are not supported. [reference](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#position) Co-authored-by: Brian Gernhardt <brian@gernhardtsoftware.com>
cyyever
pushed a commit
to cyyever/ale
that referenced
this pull request
Jul 11, 2022
* Advertise codeActionLiteralSupport to LSP server Without this, rust-analyzer doesn't return any code actions. With it, everything works properly. * linter fixes * test cases fixes * Fix underflow of column in position. Special values like for example -1 to denote the end of a line are not supported. [reference](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#position) Co-authored-by: Brian Gernhardt <brian@gernhardtsoftware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why the Pull Request?
As per ale dev philosophy point 8 this feature is added to allow use code actions like import fixes, implementation of interfaces. This could fix
no code action received from servermentioned in #3523.The working is based on allowing lsp with capability
CodeActionClientCapabilitieswithcodeActionLiteralSupportto advertise as such.Tasks
References
Credits: @Benabik for initial version