Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for actionlint options #4216

Merged
merged 2 commits into from
May 29, 2022

Conversation

iromli
Copy link
Contributor

@iromli iromli commented May 26, 2022

The changeset adds support for specifying options for actionlint linter.

Copy link
Contributor

@hsanson hsanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good , but there are some linter issues that need fixing. The help file tags are misaligned:

doc/ale-yaml.txt:g:ale_yaml_actionlint_options                *g:ale_yaml_actionlint_options*
doc/ale-yaml.txt:                                             *b:ale_yaml_actionlint_options*

@iromli
Copy link
Contributor Author

iromli commented May 29, 2022

Looks good , but there are some linter issues that need fixing. The help file tags are misaligned:

doc/ale-yaml.txt:g:ale_yaml_actionlint_options                *g:ale_yaml_actionlint_options*
doc/ale-yaml.txt:                                             *b:ale_yaml_actionlint_options*

@hsanson thanks for pointing me out. I have updated the doc.

@iromli iromli requested a review from hsanson May 29, 2022 10:01
Copy link
Contributor

@hsanson hsanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.

@hsanson hsanson merged commit 8761408 into dense-analysis:master May 29, 2022
cyyever pushed a commit to cyyever/ale that referenced this pull request Jul 11, 2022
* Add support for actionlint options

* fix misaligned doc tags
cyyever pushed a commit to cyyever/ale that referenced this pull request Jul 11, 2022
* Add support for actionlint options

* fix misaligned doc tags
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants