Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cairo support #4256

Merged
merged 3 commits into from
Jul 22, 2022
Merged

cairo support #4256

merged 3 commits into from
Jul 22, 2022

Conversation

swan-of-bodom
Copy link
Contributor

Where are the tests?

  1. ./test/linter/test_starknet.vader
  2. ./test/handler/test_starknet_handler.vader

@swan-of-bodom
Copy link
Contributor Author

Pull request for support of the programming language "Cairo" for writing contracts on Starknet.

hsanson
hsanson requested changes Jul 19, 2022
View reviewed changes
Copy link
Contributor

@hsanson hsanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add an entry for the new linter into the doc/ale-supported-languages-and-tools.txt file. Make sure is ordered the same way supported-tools.md is/

@swan-of-bodom
Copy link
Contributor Author

Added Cairo to the doc/ folder, thanks

hsanson
hsanson requested changes Jul 20, 2022
View reviewed changes
Copy link
Contributor

@hsanson hsanson left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry we also need to add these two lines between "c" and "chef" entries in the list of supported tools in doc/ale.txt file:

  cairo...................................|ale-cairo-options|
    starknet..............................|ale-cairo-starknet|

Should look like:

  c.......................................|ale-c-options|
    astyle................................|ale-c-astyle|
    cc....................................|ale-c-cc|
    ccls..................................|ale-c-ccls|
    clangd................................|ale-c-clangd|
    clang-format..........................|ale-c-clangformat|
    clangtidy.............................|ale-c-clangtidy|
    cppcheck..............................|ale-c-cppcheck|
    cquery................................|ale-c-cquery|
    cspell................................|ale-c-cspell|
    flawfinder............................|ale-c-flawfinder|
    uncrustify............................|ale-c-uncrustify|
  cairo...................................|ale-cairo-options|
    starknet..............................|ale-cairo-starknet|
  chef....................................|ale-chef-options|
    cookstyle.............................|ale-chef-cookstyle|
    foodcritic............................|ale-chef-foodcritic|

@swan-of-bodom
Copy link
Contributor Author

No problem, added them now :)

@hsanson hsanson merged commit 0ea5387 into dense-analysis:master Jul 22, 2022
mnikulin pushed a commit to mnikulin/ale that referenced this pull request Nov 12, 2023
@swan-of-bodom @mnikulin
cairo support (dense-analysis#4256)
4c9998f 
* cairo support

* supported languages txt

* add cairo to ale.txt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsanson hsanson hsanson requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@swan-of-bodom @hsanson