Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pyright config files to project root files list #4321

Merged
merged 1 commit into from
Sep 30, 2022

Conversation

andreasdoll
Copy link
Contributor

Add configuration files for pyright (JSON and TOML) to list of files which identify a project root directory. Update documentation accordingly.

Fixes #3964

This root-defining file list seems not to be tested as a quick comparison with `flake8`` tests indicates - hence no tests added for this PR as well.

Add configuration files for pyright (JSON and TOML) to list of files
which identify a project root directory. Update documentation
accordingly.
Copy link
Contributor

@hsanson hsanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good.

@hsanson hsanson merged commit 915dc41 into dense-analysis:master Sep 30, 2022
mnikulin pushed a commit to mnikulin/ale that referenced this pull request Nov 12, 2023
)

Add configuration files for pyright (JSON and TOML) to list of files
which identify a project root directory. Update documentation
accordingly.

Co-authored-by: Andreas Doll <andreas.doll@posteo.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pyright doesn't find parent pyrightconfig.json; can only use config found within the same directory as a file
2 participants