Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nix: handle versions past 2.9 #4394

Merged
merged 1 commit into from
Dec 25, 2022
Merged

nix: handle versions past 2.9 #4394

merged 1 commit into from
Dec 25, 2022

Conversation

Goorzhel
Copy link
Contributor

Same problem as #4045, with Nix now at 2.12.

Copy link
Contributor

@hsanson hsanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for keeping nix updated.

@hsanson hsanson merged commit 4c5c47b into dense-analysis:master Dec 25, 2022
@w0rp
Copy link
Member

w0rp commented Dec 25, 2022

It would be nice to flip the logic around so we check for older nix versions and default to the newer command. The oldest version that supports the newer command string came out a while ago now.

@Goorzhel
Copy link
Contributor Author

check for older nix versions and default to the newer command

Damn, I should've thought of this. The only other idea I had was to write a proper version comparison function, but I'm not nearly good enough at Vimscript for that. New PR later today.

mnikulin pushed a commit to mnikulin/ale that referenced this pull request Nov 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants