-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for gjs template linting using embertemplate lint #4653
Conversation
feel free to close this PR, it is just a proof of concept. |
You might not be far off a solution. Is there any easy way to detect if a file is an embertemplatelint file? Do other plugins fix the filetypes so the templates have a filetype like |
I think @chancancode can help here, I think the easy way is only to look at |
If the files will always have that file extension, you can just check if the file contains the file extension. We should only need to do this if filetype detection isn't reliable already. If the Vim filtetype is |
Interesting... any ideas on how to reuse the implementation? eg have 1 linter rule across both javascript.glimmer and html? also going to ping @NullVoxPopuli who use Vim in case he has ideas on how to sort this out? |
I've never tried to get template-lint going via ale.
|
also moves handler to the glimmer directory so it only fires for gjs files
Hi @w0rp this should be good to merge now, I tested and it is working correctly. Extra linting only happens on gjs files (which are classified as glimmer). Since hbs files can not be auto detected as glimmer, we needed a handler to reuse code. |
@w0rp sorry for nagging, I get holidays/life get in the way, have you had a chance to have a look? |
@w0rp I don't think this CI failure is related, PR is working well and us tidy now |
@SamSaffron the tests fail because this PR changes the name of some functions, specifically
To fix this you need to update the corresponding test file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, thanks.
thanks heaps for merging @hsanson |
No description provided.