Add profile, other options to the perlcritic linter #675
Conversation
This should bring the `perlcritic` linter in line with the `perl` linter, allowing for custom (and per-buffer) perlcritic options and executable. We also supply a "standard" perltidy profile setting..
ale_linters/perl/perlcritic.vim
Outdated
| \ get(g:, 'ale_perl_perlcritic_executable', 'perlcritic') | ||
|
|
||
| let g:ale_perl_perlcritic_profile = | ||
| \ get(g:, 'ale_perl_perlcritic_profile', '.../.perlcriticrc') |
There was a problem hiding this comment.
You should use the ale#path#FindNearestFile function below to find .percriticrc instead. See the JSHint implementation for an example.
There was a problem hiding this comment.
Thanks for that -- I'd mistaken the ... as something perlcritic does, rather than a shell construct.
ale_linters/perl/perlcritic.vim
Outdated
| let l:critic_verbosity = '%l:%c %m [%p]\n' | ||
| endif | ||
|
|
||
| return "perlcritic --verbose '". l:critic_verbosity . "' --nocolor" | ||
| return ale_linters#perl#perlcritic#GetExecutable(a:buffer) |
There was a problem hiding this comment.
You should apply ale#Escape to the executable here if it's configurable, as the executable path could contain spaces, etc.
There was a problem hiding this comment.
Done. I've also applied it to the profile file.
test/test_perlcritic_linter.vader
Outdated
|
|
||
| Before: | ||
| runtime ale_linters/perl/perlcritic.vim | ||
| silent noautocmd new testfile.pl |
There was a problem hiding this comment.
I recommend using ale#test#SetFilename instead. new produces weird output when you run the Vader tests inside of Vim while editing the tests.
|
I think there might be a commit you haven't pushed yet. |
|
There is :) I'm having trouble with your last comment, concerning the use of I think I'm just going to bypass that and use a |
Update how we search for profile, setting up a scratch buffer for the Vader tests, etc.
|
Cheers! 🍻 |
|
Thanks! :) |
This should bring the
perlcriticlinter in line with theperllinter, allowing for custom (and per-buffer) perlcritic options and
executable.
We also supply a "standard" perltidy profile setting.