Look for ini file to spot python project root #755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When looking for the project root folder it would be better to check for some well-known init file instead of __init__.py. Indeed, with python3 it is now possible to have namespace modules where intermediate dirs are not required to include the __init__.py file.
w0rp
requested changes
Jul 11, 2017
autoload/ale/python.vim
Outdated
|
|
||
| function! ale#python#FindProjectRootIni(buffer) abort | ||
| for l:path in ale#path#Upwards(expand('#' . a:buffer . ':p:h')) | ||
| if filereadable(l:path . 'MANIFEST.in') || filereadable(l:path . '/setup.cfg') || filereadable(l:path . '/pytest.ini') || filereadable(l:path . '/tox.ini') |
There was a problem hiding this comment.
Break your or conditions over several lines with \||. Look at similar code.
autoload/ale/python.vim
Outdated
| let l:ini_root = ale#python#FindProjectRootIni(a:buffer) | ||
| if !empty(l:ini_root) | ||
| return l:ini_root | ||
| endif |
There was a problem hiding this comment.
Add blank lines before and after if statements and so on that don't start a new block.
w0rp
requested changes
Jul 11, 2017
|
The comment above |
rsrchboy
added a commit
to rsrchboy/ale
that referenced
this pull request
Jul 15, 2017
* upstream/master: (23 commits) dense-analysis#764 - Update the documentation to mention how to echo messages with the ALELint autocmd Simplify the tests for the ALELint autocmd command Add scalastyle linter (dense-analysis#766) dense-analysis#697 - Remove highlights more thoroughly dense-analysis#769 Ignore stderr output and output without JSON we can read for rubocop Make tsserver completion more reliable, but not quite ready for documentation yet Rubocop: handle empty 'files' array in output Fix dense-analysis#760 - Report problems with configuration files for rubocop Add rails_best_practices handler (resolves dense-analysis#655) (dense-analysis#751) Fix docs for FindProjectRoot function Fixup dense-analysis#756 dense-analysis#756 Escape the paths used for the --include parameter for gometalinter, which uses RE2 Fix documentation typo Fix dense-analysis#747 - Lint and fix files after they have been been written to disk, not during writing them Look for ini file to spot python project root (dense-analysis#755) Make gometalinter work again Prefer --fast for stack-build (dense-analysis#754) Fix comment typo Brakeman: Remove unused cache var from tests Kotlin and general Gradle support. (dense-analysis#745) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When looking for the project root folder it would be better to check for some well-known init file instead of init.py. Indeed, with python3 it is now possible to have namespace modules where intermediate dirs are not required to include the init.py file.