-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added fixer for Standard linter #781
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add some Vader tests to cover these functions.
|
||
function! ale#fixers#standard#GetExecutable(buffer) abort | ||
return ale#node#FindExecutable(a:buffer, 'javascript_standard', [ | ||
\ 'node_modules/standard/bin/cmd.js', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should probably ensure that the cmd.js
version is executed with node
in the Fix
function below on Windows. See the eslint function for an example.
@sumnerevans The tools are just listed in the table with the linters. |
I'm in the process of adding the Vader tests (I've never done them before so it's a good learning opportunity 😄). If all goes well, I'll push sometime today or tomorrow. |
If you run into trouble installing Docker for running all of the tests, your problem is probably going to be that you need to add your user to a |
@w0rp, I actually already have Docker installed and I was happy to see how easy it was to run the tests. (I also use Linux which always helps things go smoother 😉.) |
Cool. |
@w0rp, how does it look now? I added some stuff to the eslint test directory. Should I create a different directory instead? I could also rename the |
The Fix function looks fine. I don't think you committed the tests, though. |
@w0rp, whoops. I totally forgot to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, looks good. 👍
Cheers! 🍻 |
Addresses #780.
@w0rp, is there anywhere that the available fixers are listed?