Added clang-tidy for C, too. #827
Conversation
A limited number of clang-tidy checks can be used with C, too. I pretty much copied and refactored the C++ clang-tidy linter, and added some documentation about C-compatible checks.
ale_linters/c/clangtidy.vim
Outdated
| " C++ | ||
| " | ||
| " Here is an incomplete list of C-compatible checks for clang-tidy version 6: | ||
| " bugprone-suspicious-memset-usage |
There was a problem hiding this comment.
This is an awfully large comment, here and below. Could you replace this with a link to the clang-tidy documentation?
There was a problem hiding this comment.
Sure. I put the list here because the documentation only lists all of the checks, without any indication if they work for C, or just C++. I actually went through all of them by hand and picked out those that work for C.
doc/ale-c.txt
Outdated
| readability-simplify-boolean-expr | ||
|
|
||
|
|
||
| g:ale_c_clangtidy_executable *g:ale_c_clangtidy_executable* |
There was a problem hiding this comment.
GitHub makes it look like the helptag isn't aligned to the right margin. Make sure they all are. There's an ALEFix function for aligning help tags to the right margin you can use.
There was a problem hiding this comment.
Okay. Should I flatten the commits into one after I fix everything?
There was a problem hiding this comment.
Nah, I actually prefer having many commits for pull requests, so I can see the difference before and after reviews. Then I just squash the pull request into one commit after that via GitHub's button for --ff --squash.
|
Cool, now you can add some Vader tests. |
|
I added a Vader test for this by copying the C++ one, and I linked the C++ documentation for the build directory options to the C file. |
A limited number of clang-tidy checks can be used with C, too. I pretty much
copied and refactored the C++ clang-tidy linter, and added some documentation
about C-compatible checks.