Make ghc-mod linter check current buffer #846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
w0rp
requested changes
Aug 13, 2017
There was a problem hiding this comment.
There are two options here.
- Also set
'lint_file': 1, so only files on disk will be checked on open, save, etc. - Figure out if there's some way to get this working with a temporary file, maybe by using
cd ... &&, or passing an argument for telling GHC where the Cabal file is, or by passing some argument to say where the actual file is, etc.
The second option is preferable, if possible.
|
Looks like ghc-mod have a |
|
Cool, that might do the trick. 👍 |
Right now ghc-mod linter check temp file instead of current buffer, which cause the problem that it can't detect cabal file and raise missing package error. To fix that we need to run ghc-mod check with actual path of the current file and with ghc-mod option `--map-file` to redirect temp file source code to actual one
|
Ready for review 🎉 |
w0rp
approved these changes
Aug 13, 2017
|
Cheers! 🍻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now ghc-mod linter check temp file instead of current buffer,
which cause the problem that it can't detect cabal file and raise
missing package error.
IP/s: try to look at the test but can't find ghc-mod specific test.