Add elm-format as a new fixer #916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
w0rp
requested changes
Sep 9, 2017
autoload/ale/fixers/format.vim
Outdated
| return ale#node#FindExecutable(a:buffer, 'elm_format', [ | ||
| \ 'node_modules/.bin/elm-format', | ||
| \ 'node_modules/elm-format/bin/elm-format', | ||
| \ 'node_modules/elm-format/index.js', |
There was a problem hiding this comment.
For at least this file, you will have to execute it with node on Windows, or it could lead to the .js file being opened in a text editor or similar. Look at the code for the eslint fixer for an example.
There was a problem hiding this comment.
I made a mistake here, I just had a look on this file and it's like an installer, so I will remove it. The 'node_modules/.bin/elm-format' is enough
autoload/ale/fixers/format.vim
Outdated
| " Description: Integration of Elm with ALE. | ||
|
|
||
| call ale#Set('elm_format_executable', 'elm-format') | ||
| call ale#Set('elm_format_use_global', 1) |
There was a problem hiding this comment.
Set this to 0 by default, to match the other options. Local versions should be tried first, then global versions, by default.
|
Oh yes, don't forget to document the new options too. |
|
Cheers! 🍻 |
cwonrails
added a commit
to cwonrails/ale
that referenced
this pull request
Sep 10, 2017
* 'master' of git://github.com/w0rp/ale: Explain the table of contents script better, and simplify it a bit Fix numerous issues with integration documentation tags and the table of contents, and add a script to check for theses issues Move scripts for tests into the test directory, and do not export the Batch script for running tests Elm local install support (dense-analysis#915) Fix an SML variable init bug, and get the SML cm file tests to pass on Windows Get the TSLint handler tests to pass on Windows Simplify some Rust handler code, and get the Rust handler tests passing on Windows Add elm-format as a new fixer (dense-analysis#916) Fix some path issues, and get lsp dir tests passing on Windows execute the `set encoding` test setting to get Vint to shut up Fix more random Windows test issues dense-analysis#917 Cover the old _args option for flake8 with a test, just in case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new fixer: elm-format