Skip to content

Commit

Permalink
Add more invalid URLs to specs
Browse files Browse the repository at this point in the history
These are now invalid after twingly#158. I think we can close twingly#74.

Close twingly#74
  • Loading branch information
dentarg committed Oct 8, 2022
1 parent f95151c commit c148bed
Showing 1 changed file with 6 additions and 4 deletions.
10 changes: 6 additions & 4 deletions spec/lib/twingly/url_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,12 @@ def invalid_urls
"http://.twingly.com/",
"http://www.twingly.",
"http://www..twingly..com/",

# Test that we can handle upstream bug in Addressable, references:
# https://github.com/twingly/twingly-url/issues/62
# https://github.com/sporkmonger/addressable/issues/224
"http:// shouldfail.com",
"http://-a.b.co",
"http://a.b-.co",
"http://.www.foo.bar./",
"http://club].no/",
"http://www,google.com",
"http://some_site.net%C2",
"http://+%D5d.some_site.net",

Expand Down

0 comments on commit c148bed

Please sign in to comment.