[tn48m] Add new platform TN48M2-SWDEV #217
Conversation
| @@ -40,6 +40,7 @@ typedef enum plat_id { | |||
| PID_TN4810M_PVT, | |||
| PID_TN48M2, | |||
| PID_TN4810M_NONPVT, | |||
| PID_TN48M2_SWDEV, | |||
There was a problem hiding this comment.
Sort it (below PID_TN48M2)?
There was a problem hiding this comment.
Most of the IDs are fixed by HW, its not suitable to disarray them.
There was a problem hiding this comment.
Understood. It’d be nice, if you mentioned the (new) ID (number) in the commit message.
| [PLAT_PSU_ID_3] = { | ||
| .name = "DCIN", | ||
| .type = PLAT_PSU_TYPE_DC12, | ||
| .power_status_path = "/sys/bus/i2c/devices/0-0041/dcin_powergood", |
There was a problem hiding this comment.
Why is it dcin and not psu3?
There was a problem hiding this comment.
This is representing a DC power connector, there is no physical DC PSU in the box.
There was a problem hiding this comment.
Understood. Maybe mention that hardware detail in the commit message.
| @@ -0,0 +1 @@ | |||
| include $(ONL)/make/pkg.mk | |||
There was a problem hiding this comment.
Please fix the endings.
| @@ -108,7 +109,23 @@ plat_info_t gPlat_info[] = { | |||
|
|
|||
| .thermal_count = 11, | |||
| .fan_count = 3, | |||
| .psu_count = 2, | |||
| .psu_count = 3, | |||
There was a problem hiding this comment.
Please factor out changing an existing platform into a separate commit.
There was a problem hiding this comment.
Thank you, but it’d be great if you rephrased the commit message. Maybe something like:
With the new device model …, a third PSU has to be added, so increase and add the third PSU type.
|
reverify |
- Add new platform support for TN48M2-SWDEV to Dent-3.0. This Platform is modified from TN48M2 with the SPI flash changed to 64MB to accommodate switchdev supported ONIE. Signed-off-by: Cary Chen <cary.sc.chen@deltaww.com>
- Added support to show DC power input status in ONLP for TN48M2 platform Signed-off-by: Cary Chen <cary.sc.chen@deltaww.com>
CaryChen-Deltaww
force-pushed
the
tn48m2-dent3
branch
from
b62862d
to
c846a24
Compare
|
Added fix and changes as @paulmenzel commented |
| @@ -63,6 +63,7 @@ arm64-nxp-ls1046ardb-r0 | |||
| arm64-delta-tx4810-r0 | |||
| arm64-delta-tn4810m-r0 | |||
| arm64-delta-tn48m2-r0 | |||
| arm64-delta-tn48m2-swdev-r0 | |||
There was a problem hiding this comment.
Since the only difference is the SPI flash size, please reconsider renaming the suffix from "swdev" to something like "spi64m". The fact that the board has extra SPI can be used for other things in the HW level, and it is not specific to switch-dev, which is in the software layer only.
There was a problem hiding this comment.
I agree this platform name isn't quite distinctive, however the name was decided by our customer.
|
Hi there, do we have any schedule for this PR getting merged into main? |
Please use imperative mood.
Please make it a link (add the URL). |
|
reverify |
Additional pull request also created in Dentproject Linux repo for driver and device tree support
https://github.com/dentproject/linux/pull/9