Add IPv4 mtu tests #145
Merged
Add IPv4 mtu tests #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anton7811
requested changes
Feb 20, 2023
...Framework/DentOsTestbed/src/dent_os_testbed/test/test_suite/functional/ipv4/test_ipv4_mtu.py
Outdated
Show resolved
Hide resolved
| """ | ||
| # 1. Init interfaces | ||
| tgen_dev, dent_devices = await tgen_utils_get_dent_devices_with_tgen(testbed, [], 4) | ||
| if not tgen_dev or not dent_devices: |
There was a problem hiding this comment.
This check is done in the change_port_mtu
There was a problem hiding this comment.
If the fixture fails it will not fail the test. So this check is still necessary.
There was a problem hiding this comment.
Maybe then just returning is not the correct way to process this situation? Probably skip is better. If we just return, the test has a PASS result, but in fact, it isn't executed at all. So let's change to skip in all places.
There was a problem hiding this comment.
Then I suggest to do this in a separate PR
DentOS_Framework/DentOsTestbed/src/dent_os_testbed/test/test_suite/functional/ipv4/conftest.py
Outdated
Show resolved
Hide resolved
...Framework/DentOsTestbed/src/dent_os_testbed/test/test_suite/functional/ipv4/test_ipv4_mtu.py
Outdated
Show resolved
Hide resolved
SerhiyBoikoPLV
force-pushed
the
test_ipv4_mtu
branch
2 times, most recently
from
23e9f37
to
06b0e7c
Compare
mgheorghe
previously approved these changes
Feb 21, 2023
muchetan
previously approved these changes
Feb 21, 2023
SerhiyBoikoPLV
dismissed stale reviews from muchetan and mgheorghe
via
788deb5
- test_ipv4_oversized_mtu - test_ipv4_fragmentation Signed-off-by: Serhiy Boiko <serhiy.boiko@plvision.eu>
SerhiyBoikoPLV
force-pushed
the
test_ipv4_mtu
branch
from
788deb5
to
bff3932
Compare
mgheorghe
approved these changes
Feb 23, 2023
stavrukPLV
referenced
this pull request
in PLVision/dent-testing
Feb 27, 2023
- test_ipv4_oversized_mtu - test_ipv4_fragmentation Signed-off-by: Serhiy Boiko <serhiy.boiko@plvision.eu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Serhiy Boiko serhiy.boiko@plvision.eu