Bug 119 #123
Merged
Bug 119 #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adjusting to detect py_version rather than doing a try except clause adding a test for the is_valid_ip_address section
testing ipaddress requirements
python version_info for 2.6 isn't a dict
using with open rather than fp where possible when reading from the file
adding finally fp.close to close a file when using fp = open
using readlines in __get_last_offset, since the file is 2 lines long and
both lines are needed
changing __get_current_offset's offset to be position, since fp.tell is
character position rather than line offset
using fp.writelines with a list object to write the lines rather than
writing lines individually
adjusting to use fp.readlines for first line in order to trim the \n putting position back to offset putting path join on the same line since the variables aren't too long adding unit tests for the filetracker class
if the offset line is empty then the offset should be set to 0 adding a unit test that covers the bug's issue
using platform module to determine the os being used to place denyhosts
in th ecorrect location
using sh instead of bash fixing directory check syntax updating python3 location detection updating files in the current path using pwd
# Conflicts: # python3Conversion.sh
adding test_add_hostname fqdn and nonfqdn adding dump_hosts test adding test_cleared_warned_hosts adding test_save_warned_hosts_empty
Allowed hosts unittests
Counter unittests
updating lock file to use with open adding data\lockdir for the unittest create unit tests for lockfile to increase code coverage testing
Lockfile unittests
using with open in the __save_received_hosts method
adding unit tests for get_plural
adding tests for tests_util to get more code coverage
adding setup to allow using self.report for the Report class adding additional tests for more code coverage
updating test_report unittests
Util unittests
adjusting the timestamp being set from throwing an error is the line is
an empty string. By default timestamp will return 0 if nothing is
set in the SYNC_TIMESTAMP file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusting how the sync timestamp gets pulled to prevent an error from being thrown if there hasn't been a previous sync time.
#119