Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No git indicator if file is modified and renamed #101

Closed
salmanulfarzy opened this issue May 11, 2017 · 3 comments
Closed

No git indicator if file is modified and renamed #101

salmanulfarzy opened this issue May 11, 2017 · 3 comments
Assignees
@salmanulfarzy
Labels
bug Bug related to code base, behavior, displaying, etc.
Milestone
v3.0.0

Comments

@salmanulfarzy
Copy link
Member

No indicator is shown if file is both renamed and modified. Apparently because OMZ git lib doesn't recognize RM git status and we're depending on it for git indicators.

Screenshot

spaceship no rm indicator
@denysdovhan
Copy link
Member

@sfarzy seems like OMZ-related issue. Have you reported it to their issues?

@denysdovhan denysdovhan added the bug Bug related to code base, behavior, displaying, etc. label May 11, 2017
@salmanulfarzy
Copy link
Member Author

Not yet. Looking at the state of response to issues and PRs in OMZ I don't think there is going to be any difference. However, I'll try to send patch to OMZ.

I was just giving a heads up.

@salmanulfarzy salmanulfarzy mentioned this issue Jun 21, 2017
Merged
@denysdovhan denysdovhan modified the milestone: v3.0 Jun 24, 2017
@denysdovhan
Copy link
Member

This issue was fixed by #147.

@Muratzero21 Muratzero21 mentioned this issue Jul 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@salmanulfarzy salmanulfarzy

Labels
bug Bug related to code base, behavior, displaying, etc.
Milestone
v3.0.0
Development

No branches or pull requests
2 participants
@denysdovhan @salmanulfarzy