Expose prompt character color variables

[salmanulfarzy]

Prompt character colors can be modified as below

• SUCCESS_COLOR : Prompt character color if last command succeeds
• FAILURE_COLOR : Prompt character color if last command returns non-zero exit-code
• SECONDARY_COLOR : Secondary prompt character color

Close #98

[denysdovhan]

Not sure about SUCCESS and FAILURE 🤔

[denysdovhan]

Maybe better to expose other settings, like prefix or suffix?

[salmanulfarzy]

Not sure about SUCCESS and FAILURE 🤔

Maybe better to expose other settings, like prefix or suffix?

Sorry, I don't understand. Is this about variable names or the variables itself ?

[denysdovhan]

@sfarzy I'm not sure about variable names. However, ZERO and NOZERO seem ugly.

[salmanulfarzy]

Any suggestions ?

[rjwestman]

This bash scripting guide calls it successful/unsuccessful.
So maybe:
SPACESHIP_CHAR_COLOR_EXITCODE_SUCCESSFUL
and
SPACESHIP_CHAR_COLOR_EXITCODE_UNSUCCESSFUL

I would not seperate CHAR and COLOR since seperated they dont make sense (e.g. SPACESHIP_CHAR_EXITCODE_SUCCESSFUL_COLOR) Especially since the USER_COLOR_ROOT does it the same way.

[denysdovhan]

Well, my thoughts about this:

• SUCCESS and FAILURE seem the least ugly than other proposed names.
• CHAR should have it's own prefixes and suffixes, like other sections do.
• SECONDARY is OK, however we have to let users change the secondary character too.
• Merging this PR right now would cause an inconsistency. Colors will be exposed as CHAR, but character itself will be under the PROMPT group of options. This means we have to break API.

I propose to discuss this a bit more and release this feature with v3.0 (#148) with other breaking changes.